Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use codes::Instruction in emulator::CPU #11

Closed
jeremyBanks opened this issue Jul 14, 2018 · 2 comments
Closed

Use codes::Instruction in emulator::CPU #11

jeremyBanks opened this issue Jul 14, 2018 · 2 comments

Comments

@jeremyBanks
Copy link
Owner

jeremyBanks commented Jul 14, 2018 •
edited
Loading

Initially, the only logic we'll be using is decoding individual instructions -- not touching the ROM types.

This will still require a lot of change, and possibly some horrible giant match blocks until/unless Rust eventually adds impl for enum variants: rust-lang/rfcs#1450.
@jeremyBanks jeremyBanks mentioned this issue Jul 20, 2018
Closed
jeremyBanks added a commit that referenced this issue Aug 2, 2018
@jeremyBanks
Updating emulator::CPU to use codes::Instruction. Incomplete, partial…
b8b3aa5 
…ly broken.

see #11
jeremyBanks added a commit that referenced this issue Aug 3, 2018
@jeremyBanks
Updating emulator::CPU to use codes::Instruction. Incomplete, partial…
23a2551 
…ly broken.

see #11
jeremyBanks added a commit that referenced this issue Aug 3, 2018
@jeremyBanks
Update emulator::CPU to use codes::Instruction.
305d82f 
see #11
@jeremyBanks
Copy link
Owner Author

This is mostly done, but something is broken -- the logo tiles aren't being initialized.

@jeremyBanks
Copy link
Owner Author

Fixed. I'd swapped some flags when converting the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeremyBanks