Use private key contensts instead of key path #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy379
reviewed
Sep 26, 2023
|
@jeremy379 rebased |
jeremy379
approved these changes
Oct 5, 2023
|
Nice update @georgeboot! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way the pass the private key into the IdTokenResponse.
Because some people deploy the Passport keypair as env variables (and not have them in a physical file), the old situation didn't work.
Since Laravel has already loaded the key into memory, we might as well grab the raw contents of the key and pass that along. This PR changes the behaviour to do exactly that.