Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use microtime() instead of time() when microseconds should be used #5

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

TECHNOFAB11
Copy link
Contributor

@TECHNOFAB11 TECHNOFAB11 commented Aug 30, 2023

DateTimeImmutable::createFromFormat always returned false for me resulting in an exception, this fixes the datetime parameter by using the correct type of time depending on configuration

@TECHNOFAB11 TECHNOFAB11 changed the title fix: use stringified microtime() instead of time() fix: use microtime() instead of time() when microseconds should be used Aug 30, 2023
@jeremy379
Copy link
Owner

Thank you for this fix

@jeremy379 jeremy379 merged commit d2b9ada into jeremy379:main Aug 30, 2023
@coffe4u
Copy link
Contributor

coffe4u commented Aug 31, 2023

Thanks for the quick fix on that! Sorry for the headache with my previous change.

@TECHNOFAB11
Copy link
Contributor Author

@coffe4u all good, thanks a bunch for your contributions to this library ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants