fix(ci): also update setuptools when setting up the virtual environment #793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, here’s the thing. Python 3.10.14 and 3.11.9 create a venv like so1
The problem is that setuptools v65.5.0 and below are subject to GHSA-r9hx-vwmv-q579, and should be — like pip — updated to the latest version when we set up the venv. If not, there’s a good chance that
make audit
will trigger if no other package happens to update the setuptools package…In this package we’ve been lucky because of an indirect dependency (e.g. here) and our eager update strategy:
Other packages/repos derived from this one, however, have their own dependencies and did not update setuptools (anymore) and, thus, the package audit triggered and failed CI.
Footnotes
Python 3.12 does not install setuptools by default. ↩