Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): improve automatic template synchronization #537

Merged
merged 4 commits into from
Sep 2, 2023

Conversation

jenstroeger
Copy link
Owner

Fixes #472.

Tagging @eduardocardoso because he wrote most of the original workflow.

@behnazh Do we want to add issue #509 to this change as well?

@jenstroeger jenstroeger requested a review from behnazh as a code owner May 5, 2023 22:48
eduardocardoso
eduardocardoso previously approved these changes May 10, 2023
@jenstroeger
Copy link
Owner Author

jenstroeger commented May 14, 2023

Github defines a ready_for_review PR activity type (docs) which runs a workflow when the PR is ready (i.e. not in Draft mode).1

I wonder if we should add that to our pr-change-set.yaml workflow here, then open the auto-sync PRs in Draft mode here — to avoid running the workflows, failing them (because they always do if there were merge conflicts), to avoid sending spam emails about failed PRs whenever we update the upstream template.

Footnotes

  1. I think we discussed previously that we may not want to run workflows on Draft PRs 🤔

@jenstroeger jenstroeger requested a review from behnazh July 19, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants