Update install-proxmox.sh to add RaspberryMatic logo and link in Proxmox description

[ArnaudFeld]

Description

Related Issue

No Issue, Update install-proxmox.sh to add RaspberryMatic logo and link in Proxmox description

Types of changes

Update install-proxmox.sh to add RaspberryMatic logo and link in Proxmox description

Alternate Designs

Possible Drawbacks

Verification Process

Release Notes

Contributing checklist

• [ x ] My code follows the code style of this project.
• [ x ] I have read the CONTRIBUTING and LICENSE document.
• [ x ] I fully agree to distribute my changes under Apache 2.0 license.

Summary by CodeRabbit

• New Features
  • Enhanced installation process for RaspberryMatic on Proxmox with improved VM description format, now featuring an HTML link and image for better presentation.
  • Streamlined checks for existing packages and dependencies, ensuring necessary configurations are in place before installation.
• Bug Fixes
  • Improved error handling and logging for clearer user feedback during the installation process.
  • Updated cleanup procedures to remove temporary directories upon script exit.
• User Experience
  • Added clearer prompts and confirmations to enhance user interaction during installation.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The install-proxmox.sh script has been updated to enhance the installation process for RaspberryMatic on Proxmox. Key modifications include changing the VM and CT description format to HTML for improved presentation, refining error handling and logging, and streamlining package installation checks. The script now includes better validation for kernel modules and device tree overlays specific to Raspberry Pi systems, as well as clearer user prompts during the installation and update processes.

Changes

File

Change Summary

scripts/install-proxmox.sh

- Updated VM and CT description to use HTML format with an image link. - Improved error handling and logging, refining the error_exit function. - Enhanced cleanup function to remove temporary directories. - Streamlined package installation checks using pkg_installed. - Added checks for kernel modules and device tree overlays for Raspberry Pi. - Modified update function for better container status checks and user prompts.

Possibly related PRs

• Update install-proxmox.sh to add RaspberryMatic logo and link in Proxmox description #2894: The changes in this PR also focus on updating the install-proxmox.sh script to enhance the VM and CT description format, including an HTML link with an image, which directly relates to the modifications made in the main PR regarding the description format in qm set commands.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

scripts/install-proxmox.sh (1)

823-823: LGTM! The HTML description changes look good.

The changes enhance the visual presentation by adding the RaspberryMatic logo and link. Good use of:

• Center alignment for better presentation
• Proper HTML attributes
• Consistent implementation across VM and CT configurations

Consider adding width and alt attributes to the image for better accessibility and to prevent potential layout issues:

-<img src='https://raspberrymatic.de/wp-content/uploads/2021/07/logo.png'/>
+<img src='https://raspberrymatic.de/wp-content/uploads/2021/07/logo.png' width='200' alt='RaspberryMatic Logo'/>

Also applies to: 851-851, 892-892

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 0a3c292 and 0e17b1b.

📒 Files selected for processing (1)

• scripts/install-proxmox.sh (3 hunks)

[jens-maus]

changed your stuff to use github as img provider and also use markdown instead of lengthy html stuff. So will accept that PR. But next time do not submit PR based on your master branch, but use a dedicated branch for creating PRs.

[ArnaudFeld]

thanks for information for the next time :)