Make {Synchronous,General}NonBlockingStepExecution.stopCause volatile #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
reviewed
Nov 7, 2019
There was a problem hiding this comment.
@slonopotamus Thanks for the PR! Did you run into a bug in relation to this, or is it just something you noticed while reading the code? I think GeneralNonBlockingStepExecution would also need to be updated, right?
I have no idea how likely this is to be a problem in practice, but it seems fine so that start doesn't see an outdated value if an exception is thrown.
|
I was just reading through the code, no real-life bug. Yes, |
jglick
approved these changes
Nov 7, 2019
Reasoning: stopCause is used from multiple threads. In order to guarantee that task thread sees updated value, JMM requires field to be volatile.
slonopotamus
force-pushed
the
stopCause-volatile
branch
from
0f91144
to
a09dc86
Compare
slonopotamus
changed the title
dwnusbaum
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning: stopCause is used from multiple threads. In order to guarantee that task thread sees updated value, JMM requires field to be volatile.