Update to 2.426.x, simplify JSON parsing #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
added
dependencies
jglick
changed the title
jglick
approved these changes
Jul 25, 2024
| @@ -1,8 +1,6 @@ | |||
| function handlePrototype(url) { | |||
| buildFormTree(document.forms.config); | |||
| // TODO JSON.stringify fails in some circumstances: https://gist.github.com/jglick/70ec4b15c1f628fdf2e9 due to Array.prototype.toJSON | |||
There was a problem hiding this comment.
(Confirmed that the bug described in the Gist is no longer reproducible in script console of either Firefox or Chrome.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Prototype.js has been removed in 2.426.x, we can remove the no-longer needed
Object.toJSONworkaround.Testing done
mvn clean verify -DskipTests