Support system themes for Pipeline editor #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
commented
Aug 19, 2023
| @@ -191,17 +191,6 @@ | |||
| </exclusion> | |||
| </exclusions> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>io.jenkins.plugins</groupId> | |||
| <artifactId>theme-manager</artifactId> | |||
There was a problem hiding this comment.
only needed as a JavaScript API now so not needed to be in pom. We could leave it in bumping the version to ensure that the plugins work together but I don't think needed
| @@ -8,7 +8,7 @@ | |||
| "scripts": { | |||
| "dev": "webpack --config webpack.dev.js", | |||
| "prod": "webpack --config webpack.prod.js", | |||
| "start": "yarn dev -- --watch", | |||
| "start": "yarn dev --watch", | |||
There was a problem hiding this comment.
deprecation warning in my build console that yarn hasn't needed this since yarn v1.0
jglick
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends #654
see PR description in jenkinsci/theme-manager-plugin#171 for details on the change
this has no UI changes other than dark system theme is now supported as well as dark theme
Testing done
Tested with:
Submitter checklist