[JENKINS-70695] add copy to clipboard button for snippet generator #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change adds a copy to clipboard button below the field with the generated code.
raul-arabaolaza
approved these changes
Mar 1, 2023
|
affects #599 |
mawinter69
force-pushed
the
JENKINS-70695
branch
from
1e8a130 to
e47101f
Compare
jglick
reviewed
Dec 8, 2023
There was a problem hiding this comment.
Looks reasonable though IIUC it is tricky to test locally since only https-protocol pages will actually let you copy. https://github.com/jglick/jenkins-demo-reverse-proxy might help.
|
As |
mawinter69
commented
Dec 8, 2023
| @@ -21,6 +21,9 @@ function handlePrototype(url, crumb) { | |||
| if (response.ok) { | |||
| response.text().then((responseText) => { | |||
| document.getElementById('prototypeText').value = responseText; | |||
| copybutton = document.querySelector('.jenkins-copy-button'); | |||
There was a problem hiding this comment.
I could wrap that also in a check of isSecureContext to avoid showing the copy button when it will not work anyway
There was a problem hiding this comment.
Probably not relevant for production uses.
Ah TIL. |
jglick
approved these changes
Dec 8, 2023
| @@ -21,6 +21,9 @@ function handlePrototype(url, crumb) { | |||
| if (response.ok) { | |||
| response.text().then((responseText) => { | |||
| document.getElementById('prototypeText').value = responseText; | |||
| copybutton = document.querySelector('.jenkins-copy-button'); | |||
There was a problem hiding this comment.
Probably not relevant for production uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change adds a copy to clipboard button below the field with the generated code
See JENKINS-70695