Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Dependabot ignore Groovy and do not specify explicit remoting version in groovy-cps-dgm-builder #621

Merged
merged 3 commits into from
Nov 9, 2022

Conversation

dwnusbaum
Copy link
Member

Replaces #618 and #619.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@dwnusbaum dwnusbaum requested a review from a team as a code owner November 7, 2022 14:57
@dwnusbaum dwnusbaum changed the title Dependency updates Make Dependabot ignore Groovy and do not specify explicit remoting version in groovy-cps-dgm-builder Nov 7, 2022
@dwnusbaum dwnusbaum added the dependencies Pull requests that update a dependency file label Nov 7, 2022
@@ -9,6 +9,8 @@ updates:
directory: "/"
schedule:
interval: "weekly"
ignore:
- dependency-name: org.codehaus.groovy:groovy
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we will also need to ignore org.codehaus.groovy:groovy:sources? I'm not sure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can add later if it keeps popping up

@car-roll car-roll enabled auto-merge November 9, 2022 15:53
@car-roll car-roll merged commit b8a6628 into jenkinsci:master Nov 9, 2022
@dwnusbaum dwnusbaum deleted the dependency-updates branch November 9, 2022 16:43
@@ -42,7 +42,7 @@
<changelist>999999-SNAPSHOT</changelist>
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
<jenkins.version>2.346.3</jenkins.version>
<groovy.version>2.4.21</groovy.version>
<groovy.version>2.4.21</groovy.version> <!-- TODO: Add org.codehaus.groovy:groovy and org.codehaus.groovy:groovy:sources to Jenkins core BOM so this can be deleted? (currently it only specifies groovy-all) -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants