Use detached JavaMail plugin #167
Conversation
basil
force-pushed
the
javamail-upgrade
branch
from
cccaba2 to
0d9d6ac
Compare
basil
force-pushed
the
javamail-upgrade
branch
from
0d9d6ac to
995353a
Compare
| @@ -143,6 +143,12 @@ | |||
| <artifactId>javadoc</artifactId> | |||
| <version>1.6</version> | |||
| <scope>test</scope> | |||
| <exclusions> | |||
| <exclusion> | |||
|
I've marked this as ready for review because the PR is complete, but I'm not in any rush for this to be merged due to the bump in Jenkins baseline. I just wanted to file the PR to close the loop on remaining tasks regarding detaching JavaMail. |
| @@ -64,7 +64,7 @@ | |||
| <properties> | |||
| <revision>2.25</revision> | |||
| <changelist>-SNAPSHOT</changelist> | |||
| <jenkins.version>2.263.1</jenkins.version> | |||
| <jenkins.version>2.331</jenkins.version> | |||
There was a problem hiding this comment.
we should refrain using non LTS this prevents users use last version of the plugin....
There was a problem hiding this comment.
So? If and when there is some important feature/fix that cannot wait for the next LTS line, https://gist.github.com/jglick/86a30894446ed38f918050c1180483e2 is easy enough.
There was a problem hiding this comment.
why not but it's not something so simple and probably not obvious for the majority of the plugins maintainers.
probably worth some documentation somewhere.
how do that work with CD?
does the cd tooling can detect he needs to generate something between 23343_kljffe0345 and 53343_kljloe0345?
There was a problem hiding this comment.
probably worth some documentation somewhere.
Agreed.
how do that work with CD?
The same Gist shows an example. Again, yes, deserves formal documentation and perhaps some tooling to make it easier and more discoverable.
Downstream of #166 and jenkinsci/jenkins#6165. Bumps the baseline to one containing jenkinsci/jenkins#6165, thus using the detached JavaMail plugin, but does not upgrade to Jakarta Mail.