Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt DirectArtifactManagerFactory to run test on IPv6 #317

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

imonteroperez
Copy link
Contributor

@imonteroperez imonteroperez commented Jan 23, 2024

Highlights

  • Current use of URL builder does not cover IPv6
  • If we run a test using this code on an IPv6 environment we will get the following exception
java.net.MalformedURLException: Error at index 0 in: "::45033"
	at java.base/java.net.URL.<init>(URL.java:679)
	at java.base/java.net.URL.<init>(URL.java:541)
	at java.base/java.net.URL.<init>(URL.java:488)
	at org.jenkinsci.plugins.workflow.DirectArtifactManagerFactory.<init>(DirectArtifactManagerFactory.java:105)
  • This PR changes the URL builder invocation to a compliant one with both IPv4 and IPv6 addresses format

Testing done

  • Tested via PCT on an IPv6 environment and working as expected

Submitter checklist

@imonteroperez imonteroperez requested a review from a team as a code owner January 23, 2024 15:38
@rsandell rsandell merged commit acf779f into jenkinsci:master Jan 23, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants