Revert "Use official Jenkins CI to build and test winp"
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, we do not accept regressions. Prior to #116, the repository was in a state such that changes to native code were not releasable but changes to non-native code (such as #69 and #127) were releasable. #116 (in the absence of #117) regressed the ability to release changes to non-native code, but this temporary situation seemed acceptable under the assumption that #117 would be completed shortly thereafter. Since #117 has not been completed in a timely fashion, I am reverting #116 (and the subsequent two fixup commits) to fix this regression. It can be reintegrated (by reverting this reversion) once the fix for #117 has been prepared.
Testing done
git diffto before Use official Jenkins CI to build and testwinp#116