Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable CI for Windows #115

Closed
wants to merge 1 commit into from
Closed

Conversation

pbo-linaro
Copy link
Contributor

As discussed on #112, this PR will try to enable CI for windows, by using existing jenkins infrastructure (https://ci.jenkins.io/job/jenkinsci-libraries/job/winp/job/master/).

Windows platform was explicitely disabled because native binaries are not available.
This PR will reproduce this, and fix this in a clean way.
Since it's hard to reproduce Jenkins pipeline out of official infra, this PR will serve as a playground.

@pbo-linaro
Copy link
Contributor Author

pbo-linaro commented Apr 15, 2024

Despite adding windows as list of configuration to test, it seems that jenkins pipeline only runs linux configuration.
https://ci.jenkins.io/job/jenkinsci-libraries/job/winp/job/PR-115/2/
What is missing here?

EDIT: seems like it's checking some permissions related to the user. What should be added to get access?

19:47:53 19:47:53  Connecting to https://api.github.com/ using 74951/****** (ci.jenkins.io GitHub App (jenkinsci org))
19:47:53  Connecting to https://api.github.com/ to check permissions of obtain list of pbo-linaro for jenkinsci/winp
19:47:53  Loading trusted files from base branch master at 1d2dacbd7585bd8614addef7597377dd9c386398 rather than cd05879eb5a9b94bcebd9747f621424e2ed5a2d6
19:47:53  Obtained Jenkinsfile from 1d2dacbd7585bd8614addef7597377dd9c386398
19:47:54  ‘Jenkinsfile’ has been modified in an untrusted revision

@timja
Copy link
Member

timja commented Apr 15, 2024

I re-ran the build for you and I can see a bunch of test failures.

I've created an origin branch which should allow you to experiment by PR'ing to the origin branch instead, although you won't be able to make any Jenkinsfile changes without someone pushing it to the origin branch for you or someone replaying the build for you.

https://github.com/jenkinsci/winp/tree/ci_windows

@pbo-linaro
Copy link
Contributor Author

Thanks @timja. For now, I'm trying to understand in which environment windows job is running. I expected to see some docker images, but it seems it's not the case (see log: https://ci.jenkins.io/job/jenkinsci-libraries/job/winp/job/PR-115/3/console). Do you have public documentation on how aci-maven-17-windows-3pn09 is setup?

@timja
Copy link
Member

timja commented Apr 15, 2024

Thanks @timja. For now, I'm trying to understand in which environment windows job is running. I expected to see some docker images, but it seems it's not the case (see log: ci.jenkins.io/job/jenkinsci-libraries/job/winp/job/PR-115/3/console). Do you have public documentation on how aci-maven-17-windows-3pn09 is setup?

Some documentation is here:
https://github.com/jenkins-infra/documentation/blob/main/ci.adoc#container-agents

The container used is:

jenkinsciinfra/inbound-agent-maven:jdk17-nanoserver@sha256:22cae7e650d55786ef1b3cbb396321059739b685bfa481fab70fcd336e266e49

I believe built from: https://github.com/jenkins-infra/docker-inbound-agents/blob/main/maven/jdk17/Dockerfile.nanoserver

@pbo-linaro
Copy link
Contributor Author

Thanks. I'll try to execute this on my local windows machine, and add a VS install step using mvn.
Once it works, I should be able to push this here, and we should be good.

@pbo-linaro
Copy link
Contributor Author

In short, I identified that VS can't be installed on nanoserver windows images.
Opened this infra ticket to discuss about a possible solution:
jenkins-infra/helpdesk#4047

Jenkinsfile Show resolved Hide resolved
@MarkEWaite
Copy link

I started a new build with the Jenkinsfile recommended by @dduportal

@pbo-linaro
Copy link
Contributor Author

Thanks, I'll open a new PR for enabling CI + changes needed.

@pbo-linaro pbo-linaro closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants