Kotlin plugin #111

sladyn98 · 2019-06-12T15:59:21Z

No description provided.

uhafner

It would be nice to have a test in ParsersITest that reads an actual file from a Kotlin build that contains a warning.

Example

[INFO] Scanning for projects...
[INFO] 
[INFO] ----------< com.michaelrice.kotlin:hello-world-maven-example >----------
[INFO] Building hello-world-maven-example 1.0
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ hello-world-maven-example ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory /Users/hafner/Development/git/kotlin-maven-hello-world/src/main/resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ hello-world-maven-example ---
[INFO] Nothing to compile - all classes are up to date
[INFO] 
[INFO] --- kotlin-maven-plugin:1.1.2:compile (compile) @ hello-world-maven-example ---
[INFO] Kotlin Compiler version 1.1.2
[INFO] Compiling Kotlin sources from [/Users/hafner/Development/git/kotlin-maven-hello-world/src/main/kotlin]
[INFO] Module name is hello-world-maven-example
[WARNING] /Users/hafner/Development/git/kotlin-maven-hello-world/src/main/kotlin/hello.kt: (4, 11) Parameter 'args' is never used
[INFO] 
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ hello-world-maven-example ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory /Users/hafner/Development/git/kotlin-maven-hello-world/src/test/resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ hello-world-maven-example ---
[INFO] No sources to compile
[INFO] 
[INFO] --- kotlin-maven-plugin:1.1.2:test-compile (test-compile) @ hello-world-maven-example ---
[INFO] Kotlin Compiler version 1.1.2
[WARNING] No sources found skipping Kotlin compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ hello-world-maven-example ---
[INFO] No tests to run.
[INFO] 
[INFO] --- maven-jar-plugin:2.6:jar (default-jar) @ hello-world-maven-example ---
[INFO] Building jar: /Users/hafner/Development/git/kotlin-maven-hello-world/target/hello-world-maven-example-1.0.jar
[INFO] 
[INFO] --- maven-assembly-plugin:2.6:single (make-assembly) @ hello-world-maven-example ---
[INFO] Building jar: /Users/hafner/Development/git/kotlin-maven-hello-world/target/hello-world-maven-example-1.0-jar-with-dependencies.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  3.100 s
[INFO] Finished at: 2019-06-12T21:47:44+02:00
[INFO] ------------------------------------------------------------------------
~/D/g/kotlin-maven-hello-world (master|✚1) $

src/main/java/io/jenkins/plugins/analysis/warnings/Kotlin.java

uhafner · 2019-06-12T19:38:10Z

src/main/java/io/jenkins/plugins/analysis/warnings/Kotlin.java

+        public String getDisplayName() {
+            return Messages.Warnings_JavaParser_ParserName();
+        }
+    }


Is there an icon available that can be included in the warnings-plugin? (Check License).

I do not think we can use the android one, so NO

See https://kotlinlang.org/docs/reference/faq.html#where-can-i-get-an-hd-kotlin-logo

src/main/java/io/jenkins/plugins/analysis/warnings/Kotlin.java

sladyn98 · 2019-06-14T04:37:17Z

@uhafner Kindly review

uhafner · 2019-06-15T09:19:45Z

The file kotlin.txt is also missing in the commits. Please also make sure that Codacy does not report any new issues.

sladyn98 · 2019-06-16T08:36:40Z

The file kotlin.txt is also missing in the commits. Please also make sure that Codacy does not report any new issues.

@uhafner Should I put the file you sent in as kotlin.txt
Also ignore the accidental close

uhafner · 2019-06-16T19:29:37Z

Well, you can use this file as kotlin.txt if you like. Your test just breaks because the file is not part of the PR. (As well as your changes in the properties file).

sladyn98 · 2019-06-17T10:51:29Z

@uhafner made the changes

uhafner · 2019-06-16T19:27:50Z

src/main/java/io/jenkins/plugins/analysis/warnings/Kotlin.java

+        public String getDisplayName() {
+            return Messages.Warnings_JavaParser_ParserName();
+        }
+    }


See https://kotlinlang.org/docs/reference/faq.html#where-can-i-get-an-hd-kotlin-logo

uhafner · 2019-06-17T11:32:05Z

src/test/java/io/jenkins/plugins/analysis/warnings/ParsersITest.java

@@ -737,7 +737,17 @@ public void shouldFindAllJavaIssues() {
        shouldFindIssuesOfTool(2 + 1 + 1 + 2, new Java(), "javac.txt", "gradle.java.log", "ant-javac.txt", "hpi.txt");
    }

-    /** Runs the CssLint parser on an output file that contains 51 issues. */
+    /**
+     * Runs the Kotlin parser on several output files that contain 4 issues.


contains 1 issue

Where do I upload the logo and do we want only a logo or a log and text with it ?

The logos are in https://github.com/jenkinsci/warnings-ng-plugin/tree/master/src/main/webapp/icons. Please add a line that references the license somehow in the License.txt file.

You can have a look at the https://github.com/jenkinsci/warnings-ng-plugin/blob/master/src/main/java/io/jenkins/plugins/analysis/warnings/AndroidLint.java to see how icons are used.

If everything is working correctly you will see the result in https://github.com/jenkinsci/warnings-ng-plugin/blob/master/SUPPORTED-FORMATS.md (after running the ToolLister).

uhafner · 2019-06-17T11:36:03Z

You can also add a new entry in the ChangeLog file and run the ToolLister test shouldPrintAllRegisteredTools, then you automatically get an update of the SUPPORTED_TOOLS document.

sladyn98 · 2019-06-17T11:41:34Z

You can also add a new entry in the ChangeLog file and run the ToolLister test shouldPrintAllRegisteredTools, then you automatically get an update of the SUPPORTED_TOOLS document.

Yeah I will make changes to the https://github.com/jenkinsci/warnings-ng-plugin/blob/master/CHANGELOG.md .
In terms of running the toolLister I did not quite get what you mean could you be a little more specific?

codecov · 2019-06-17T11:43:16Z

Codecov Report

Merging #111 into master will increase coverage by 0.23%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master     #111      +/-   ##
============================================
+ Coverage     83.14%   83.38%   +0.23%     
- Complexity     1517     1523       +6     
============================================
  Files           239      240       +1     
  Lines          5080     5087       +7     
  Branches        399      399              
============================================
+ Hits           4224     4242      +18     
+ Misses          704      695       -9     
+ Partials        152      150       -2

Impacted Files	Coverage Δ	Complexity Δ
...a/io/jenkins/plugins/analysis/warnings/Kotlin.java	`85.71% <85.71%> (ø)`	`2 <2> (?)`
...alysis/core/model/StaticAnalysisLabelProvider.java	`95.78% <0%> (+2.1%)`	`40% <0%> (+2%)`	⬆️
...kins/plugins/analysis/core/model/ResultAction.java	`78.57% <0%> (+2.38%)`	`22% <0%> (+1%)`	⬆️
...kins/plugins/analysis/core/model/IssuesDetail.java	`86.02% <0%> (+4.3%)`	`40% <0%> (ø)`	⬇️
...ugins/analysis/core/columns/IssuesTotalColumn.java	`81.33% <0%> (+6.66%)`	`13% <0%> (+1%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a29eb05...06e8a73. Read the comment docs.

uhafner · 2019-06-17T11:45:13Z

Open the class ToolLister in IntelliJ and start the Unit test. Then the supported tools are automatically updated.

sladyn98 · 2019-06-17T12:37:55Z

All changes have been made 👍

uhafner · 2019-06-17T19:08:58Z

Thank you very much for your first time contribution!

🎉

sladyn98 · 2019-06-17T19:10:15Z

@uhafner Thanks for the mentorship and advice really appreciate it. Looking forward to contributing more to this plugin.

sladyn98 force-pushed the kotlin_plugin branch 5 times, most recently from 1d6eefe to 79f137d Compare June 12, 2019 16:12

jenkinsci deleted a comment Jun 12, 2019

Added Kotlin.java to plugins

4e47bd4

sladyn98 force-pushed the kotlin_plugin branch from 79f137d to 4e47bd4 Compare June 12, 2019 16:20

jenkinsci deleted a comment Jun 12, 2019

uhafner requested changes Jun 12, 2019

View reviewed changes

Checkstyle Changes

4e4b620

sladyn98 force-pushed the kotlin_plugin branch from 4048f13 to 4e4b620 Compare June 13, 2019 06:48

Added parser test

347baae

sladyn98 force-pushed the kotlin_plugin branch from bfbc424 to 347baae Compare June 13, 2019 07:12

sladyn98 closed this Jun 16, 2019

sladyn98 reopened this Jun 16, 2019

Added kotlin.txt and resolved codacy errors

e83afd1

jenkinsci deleted a comment Jun 17, 2019

Added parser name in message.properties

f3e92cc

jenkinsci deleted a comment Jun 17, 2019

Resolved codacy errors

8395796

jenkinsci deleted a comment Jun 17, 2019

Sladyn added 2 commits June 17, 2019 14:49

Changed file path for kotlin.txt

1a37684

Fixed expected issues

d38bc21

uhafner reviewed Jun 17, 2019

View reviewed changes

Added license and icons

06e8a73

uhafner approved these changes Jun 17, 2019

View reviewed changes

uhafner merged commit ee76c41 into jenkinsci:master Jun 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kotlin plugin #111

Kotlin plugin #111

sladyn98 commented Jun 12, 2019

uhafner left a comment

uhafner Jun 12, 2019

sladyn98 Jun 13, 2019

uhafner Jun 16, 2019

sladyn98 commented Jun 14, 2019

uhafner commented Jun 15, 2019

sladyn98 commented Jun 16, 2019 •

edited

Loading

uhafner commented Jun 16, 2019

sladyn98 commented Jun 17, 2019

uhafner Jun 16, 2019

uhafner Jun 17, 2019

sladyn98 Jun 17, 2019

uhafner Jun 17, 2019

uhafner commented Jun 17, 2019

sladyn98 commented Jun 17, 2019

codecov bot commented Jun 17, 2019 •

edited

Loading

uhafner commented Jun 17, 2019

sladyn98 commented Jun 17, 2019 •

edited

Loading

uhafner commented Jun 17, 2019

sladyn98 commented Jun 17, 2019

Kotlin plugin #111

Kotlin plugin #111

Conversation

sladyn98 commented Jun 12, 2019

uhafner left a comment

Choose a reason for hiding this comment

uhafner Jun 12, 2019

Choose a reason for hiding this comment

sladyn98 Jun 13, 2019

Choose a reason for hiding this comment

uhafner Jun 16, 2019

Choose a reason for hiding this comment

sladyn98 commented Jun 14, 2019

uhafner commented Jun 15, 2019

sladyn98 commented Jun 16, 2019 • edited Loading

uhafner commented Jun 16, 2019

sladyn98 commented Jun 17, 2019

uhafner Jun 16, 2019

Choose a reason for hiding this comment

uhafner Jun 17, 2019

Choose a reason for hiding this comment

sladyn98 Jun 17, 2019

Choose a reason for hiding this comment

uhafner Jun 17, 2019

Choose a reason for hiding this comment

uhafner commented Jun 17, 2019

sladyn98 commented Jun 17, 2019

codecov bot commented Jun 17, 2019 • edited Loading

Codecov Report

uhafner commented Jun 17, 2019

sladyn98 commented Jun 17, 2019 • edited Loading

uhafner commented Jun 17, 2019

sladyn98 commented Jun 17, 2019

sladyn98 commented Jun 16, 2019 •

edited

Loading

codecov bot commented Jun 17, 2019 •

edited

Loading

sladyn98 commented Jun 17, 2019 •

edited

Loading