Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML not rendered correctly #70

Closed
tomasbjerre opened this issue Jun 25, 2015 · 4 comments
Closed

HTML not rendered correctly #70

tomasbjerre opened this issue Jun 25, 2015 · 4 comments
Assignees

Comments

@tomasbjerre
Copy link
Contributor

Need to look into this...

jenkins_violations_plugin

@tomasbjerre tomasbjerre self-assigned this Jun 25, 2015
@kheremos
Copy link

Could it be from this commit:
6dcbef2

It looks like the second table below is getting escaped when it shouldn't be. Specifically the less than and ampersands. Around line 69 of the index.jelly, it calls the violations summary, this is the content that is getting escaped either twice or unnecessarily.

I hunted this down by searching for

tags. The opening tag occurs twice for this page, once correctly, and once escaped.

@kohsuke Did you experience this at all in your testing of your contribution? If it's due to something on my end, I'd be happy to fix it!

@tomasbjerre
Copy link
Contributor Author

There is HTML in:
violations-plugin/src/main/java/hudson/plugins/violations/render/FileModelProxy.java
That should be moved to:
/violations-plugin/src/main/resources/hudson/plugins/violations/render/FileModelProxy/index.jelly
There are a bunch of bugs here... like hard coded references to images instead of using rooUrl-variable (https://wiki.jenkins-ci.org/display/JENKINS/Basic+guide+to+Jelly+usage+in+Jenkins#BasicguidetoJellyusageinJenkins-PredefinedURLs)

tomasbjerre added a commit that referenced this issue Jun 27, 2015
tomasbjerre added a commit that referenced this issue Jun 27, 2015
@tomasbjerre
Copy link
Contributor Author

@kheremos
Copy link

Looks much better, although I can't really see the difference between the
two tables:
[image: Inline image 1]
Just wanted to send you a quick message to let you know I updated to
Alpha-2. And that all appears well from my end. Also, is there a way to
disable the Visual Studio links? None of my projects are related to Visual
Studio, and I don't think they ever will be, as we're trying to go as
open-source as possible...

On Sat, Jun 27, 2015 at 1:32 AM, Tomas Bjerre notifications@github.com
wrote:

Closed #70 #70.


Reply to this email directly or view it on GitHub
#70 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants