Support for port=0 which means automatically allocated port. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed, typically from an ephemeral port range java.net.ServerSocket has support for setting port==0 and will then automatically allocate a port. trilead.LocalPortForwarder handles this fine however as a user its currently not possible to figure out which port was actually allocated in the end which this fix changes.
kuisathaverat
approved these changes
Mar 17, 2020
|
Nice, thanks for the quick merge. |
|
well, I have to release this module and the trilead-api-plugin, I guess I would find some time before the end of the week |
|
as usual, I've made a mess with the version of this module (it does not have a regular version name) so I've burned 2 versions 🤦♂ so finally, your changes are in the trilead-ssh2:build-217-jenkins-19 and trilead-api-plugin:1.0.6 |
|
big thanks :) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typically allocated from an ephemeral port range
java.net.ServerSocket has support for setting port to 0 and will then
automatically allocate a port.
trilead.LocalPortForwarder handles port 0 fine already however as a end
user its currently not possible to figure out which port was actually
allocated in the end which this fix changes.