[JENKINS-12092] Block job by category #25
Conversation
|
Sorry accidentally made this pull request too early. Comments on the Jira ticket or pull request are welcome though :) |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
oleg-nenashev
changed the title
fluffy88
force-pushed
the
block_by_category
branch
2 times, most recently
from
fef46c5 to
1e0c878
Compare
|
This is ready for review and merging |
| @@ -319,20 +322,34 @@ public ListBoxModel doFillCategoryItems() { | |||
| private Integer maxConcurrentPerNode; | |||
| private Integer maxConcurrentTotal; | |||
| private String categoryName; | |||
| private String blockingCategories; | |||
| private List<String> blockingCategoriesList = new ArrayList<String>(); | |||
| private List<NodeLabeledPair> nodeLabeledPairs; | |||
|
|
|||
| @DataBoundConstructor | |||
| public ThrottleCategory(String categoryName, | |||
There was a problem hiding this comment.
Please save the previous constructor as well. Otherwise the change affects the binary compatibility with previous versions
fluffy88
force-pushed
the
block_by_category
branch
from
1e0c878 to
ad5de7f
Compare
fluffy88
force-pushed
the
block_by_category
branch
2 times, most recently
from
521f484 to
97fd80b
Compare
|
Woohoo, fixed build failures :) |
fluffy88
force-pushed
the
block_by_category
branch
from
97fd80b to
632ecbd
Compare
fluffy88
force-pushed
the
block_by_category
branch
from
632ecbd to
7dfb26a
Compare
|
@oleg-nenashev any chance of a review for this PR? |
| } | ||
|
|
||
| private boolean isProjectBuilding(AbstractProject<?, ?> project) { | ||
| if (project.isBuilding() || project.isInQueue()) { |
There was a problem hiding this comment.
project.isBuilding() is unreliable for parallel runs; project.isInQueue() causes a full queue lookup with a serious performance impact on cores till 1.610
|
@fluffy88 We tried to somehow overcome the issue in #27 and #28 , but unfortunately now I have no time to finalize and especially test these changes. |
|
👍 that's okay with me |
jglick
changed the title
|
Any chance of this coming out? |
|
1.580.x compatibility is no longer a blocker, hence probably it could be done |
|
This would be a nice addition. In my use case I have build jobs and node provisioning jobs, both with their respective categories. The When a This PR is the best fit for this scenario. |
Allow categories to be configured so they are blocking by another category.
In category configuration, add new textbox which takes a comma separated list of category names. Jobs in the category will then be blocked from executing while jobs from any of the listed categories are queued or executing.