Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report pending and completion status to the associated VSTS commit #91

Merged
merged 11 commits into from
Jul 25, 2016

Conversation

olivierdagenais
Copy link
Member

This pull request adds a Set pending status for VSTS commit or pull request build step as well as a Set completion status for VSTS commit or pull request post-build action, as shown below in my test job:

image

Manual testing

  1. Triggered the /vsts-hook/ with a specific commit, which queued my test job.
  2. As soon as the Maven build started, I went to check on the commit in VSTS. It had indeed received the "Pending" status.
  3. As soon as the build completed successfully, I went to check on the commit in VSTS. It had indeed received a "Success" status and was linking back to the Jenkins job.
  4. I repeated the test, this time arranging for the build to fail. VSTS indeed reported a "Failure" status, also linking back to the Jenkins job.

Mission accomplished!


@Override
public String getDisplayName() {
return "Set completion status for VSTS commit or pull request";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change "VSTS" to "Team Services" here?

@davidstaheli
Copy link
Contributor

Is there a way for these pre- and post-build actions to be automatic whenever TFS or Team Services is involved, so that administrators do not have to explicitly enable them per-job?

@olivierdagenais
Copy link
Member Author

Is there a way for these pre- and post-build actions to be automatic whenever TFS or Team Services is involved, so that administrators do not have to explicitly enable them per-job?

Yes, I think there’s a way and I’ve added it to the backlog.

@olivierdagenais olivierdagenais merged commit aa88059 into master Jul 25, 2016
@olivierdagenais olivierdagenais deleted the report_status_to_vsts_steps branch July 25, 2016 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants