-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a simple VSTS REST client #88
Conversation
TRACE, | ||
; | ||
|
||
private static final Charset UTF8 = Charset.forName("UTF-8"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using java.nio.charset.StandardCharsets.UTF_8
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good idea. StandardCharsets
is Java 1.7+ and we're currently targeting Java 1.6, so I'll add an item in the backlog to upgrade to Java 1.7 (as most of Jenkins has) and to make that change at the same time.
Looks good! See 2 minor comments. |
Thank you for the review! |
In preparation for a fair amount of interactions with VSTS, created the
VstsRestClient
class as a façade. A sample of its use can be found inVstsCollectionConfiguration
, for testing the collection URL paired with the credentials.Manual testing
ping()
test and ran it with the necessary parameters to connect to a VSTS account. The ping succeeded.Mission accomplished!