Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-32394: Fix Changeset number display for Delivery Pipeline #78

Merged
merged 1 commit into from
May 25, 2016

Conversation

olivierdagenais
Copy link
Member

@olivierdagenais olivierdagenais commented May 25, 2016

Slight improvement of #76.

Manual testing

  1. Install the Delivery Pipeline Plugin.
  2. Create a new job called JENKINS-32394
    1. Check the Delivery Pipeline configuration box and configure as follows:
      1. Stage Name: Development
      2. Task Name: Build
      3. Customize Task Description Template: Build #${BUILD_NUMBER} on ${NODE_NAME}
    2. Select Team Foundation Server under Source Code Management and configure to get source code from a TFVC project.
    3. Add a build step just to see the build doing something. I used Execute Windows batch command set to dir /s
    4. Click [Save]
  3. Click Build Now on the new job.
  4. Go to the Jenkins home and click the "+" on the top tab row to add a new view and configure as follows:
    1. View name: Pipeline
    2. Select Delivery Pipeline View
    3. Click [OK]
    4. Under View settings, check Show commit messages
    5. Under Pipelines > Components, click [Add] and configure as follows:
      1. Name: Delivery
      2. Initial Job: JENKINS-32394
    6. Click [OK]
  5. Notice how there's the first build listed there. Let's go create some changesets in source control and then come back to Jenkins.
  6. Click Build Now on the new job a second time.
  7. Before the changes from this branch/pull request were applied, the second build would show the "Changes" table with "null" as the changeset ID. After these changes, the "Changes" table now shows the changeset IDs:

image

Mission accomplished!

@mosabua
Copy link
Member

mosabua commented May 25, 2016

+1

@olivierdagenais olivierdagenais changed the title JENKINS-32394: Fix Changeset number display for Delivery Pipeline DRAFT: JENKINS-32394: Fix Changeset number display for Delivery Pipeline May 25, 2016
@olivierdagenais olivierdagenais changed the title DRAFT: JENKINS-32394: Fix Changeset number display for Delivery Pipeline JENKINS-32394: Fix Changeset number display for Delivery Pipeline May 25, 2016
@pskumar448
Copy link
Contributor

@olivierdagenais
Went through the steps and the outcome of this fix, It is as working expected.

@olivierdagenais olivierdagenais merged commit 47545fd into master May 25, 2016
@olivierdagenais
Copy link
Member Author

Thank you, @pskumar448 for your contribution and your assistance in verifying the fix!

@pskumar448
Copy link
Contributor

Thanks @olivierdagenais

@thpert
Copy link

thpert commented May 25, 2016

Thanks a lot :-)

@olivierdagenais olivierdagenais deleted the delivery_pipeline branch May 26, 2016 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants