Checkout and history now go by the changeset number #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
August 5, 2015 14:55
This slightly affected two tests that are tightly coupled to the mocks.
We were already determining the changeset and recording it as part of the build, this now makes sure we use that same changeset number when retrieving the files and computing the list of changes since the last build. Without these changes, it was possible for the plugin to claim we were checking out, say, changeset 507, but actually fetch changeset 506, depending on the exact timing of the changeset and the build's start time.
This addition to the newJob() functional test exposed the case where a build was manually triggered after an SCM trigger and the plugin would end up asking for history between changesets X+1 and X, which would throw an exception. This verifies there should be no changes recorded.
olivierdagenais
added a commit
that referenced
this pull request
Aug 6, 2015
Checkout and history now go by the changeset number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, checking out (and subsequent history querying) was done using timestamps, which could lead to an inconsistency where the plugin, under certain circumstances (i.e. if the build was started on the same second as a check-in) could report the changeset associated with the build as x but the files actually fetched would be from changeset x - 1.
This pull request leverages the changeset number (already being recorded!) to perform the checkout and history querying with more precision and consistency.
Verification is mostly encoded in the
newJob()test, although some validation also took place by manual inspection of build artifacts, such as logs.