Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy TFS/Team Services URL matching #136

Merged
merged 8 commits into from
Sep 13, 2016

Conversation

olivierdagenais
Copy link
Member

As a follow-up to #110, we've since discovered a way to support TFS/Team Services Git repository URLs with and without /DefaultCollection (see ebdee65 for details).

Manual testing

  1. Configure three Jenkins jobs with the Git SCM, pointing to three variations of effectively the same Team Services Git repository URL, making sure to add the Set build completion status in TFS/Team Services post-build action:
    1. HTTPS, with /DefaultCollection. For example: https://fabrikam-fiber-inc.visualstudio.com/DefaultCollection/project/_git/repo
    2. HTTPS, without /DefaultCollection. For example: https://fabrikam-fiber-inc.visualstudio.com/project/_git/repo
    3. SSH, with /DefaultCollection. For example: ssh://fabrikam-fiber-inc@fabrikam-fiber-inc.visualstudio.com/DefaultCollection/project/_git/repo
    4. SSH, without /DefaultCollection. For example: ssh://fabrikam-fiber-inc@fabrikam-fiber-inc.visualstudio.com/project/_git/repo
  2. Manually queue each job once to make sure it's able to fetch from Git using the configured credentials, etc.
  3. Trigger a "Git pull request merged" event that contains a Git repository remote URL without /DefaultCollection. For example: https://fabrikam-fiber-inc.visualstudio.com/project/_git/repo
    1. Notice that all four jobs were queued.
    2. Notice that the Git plugin reports building the same commit for all four jobs (the commit ID came from the event payload).
    3. Notice that the list of statuses for that commit, in Team Services, includes links back to each of the jobs with the completion status.
  4. Trigger a "Git pull request merged" event with URLs containing /DefaultCollection in the payload. For example: https://fabrikam-fiber-inc.visualstudio.com/DefaultCollection/project/_git/repo
    1. Notice that all four jobs were queued.
    2. Notice that the Git plugin reports building the same commit for all four jobs (the commit ID came from the event payload).
    3. Notice that the list of statuses for that commit, in Team Services, includes links back to each of the jobs with the completion status.

Mission accomplished!

@davidstaheli
Copy link
Contributor

Looks good!

@olivierdagenais olivierdagenais merged commit 95543e1 into master Sep 13, 2016
@olivierdagenais olivierdagenais deleted the fuzzy_team_services_url_matching branch September 13, 2016 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants