Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Jackson for events parsing #116

Merged
merged 9 commits into from
Aug 15, 2016

Conversation

olivierdagenais
Copy link
Member

This branch contains no [direct] new features, just some refactoring, re-wiring and clean-up that will make it easier to add upcoming features.

@mosabua
Copy link
Member

mosabua commented Aug 12, 2016

I like the switch to Jackson. Its a great library. You should probably add an explicit dependency to it in the pom.

@olivierdagenais
Copy link
Member Author

You should probably add an explicit dependency to it in the pom.

I'm using the version that ships with the TFS SDK for Java (it's in the JAR) and thus I'm weary of over-specifying dependencies.

@mosabua
Copy link
Member

mosabua commented Aug 12, 2016

Oh.. I wasn't aware that Jackson is repackaged there. I guess thats okay then... bad practice on the TFS side, but nothing we can control.

@olivierdagenais olivierdagenais merged commit d0730cc into master Aug 15, 2016
@olivierdagenais olivierdagenais deleted the switch_to_jackson_for_events_parsing branch August 15, 2016 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants