Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate logging of each resource get in build log #106

Merged
merged 1 commit into from
Aug 4, 2016

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Aug 4, 2016

Use the same approach as in the list workspaces command.

  • wrapped flag around logging
  • set flag to false by default
  • added comment to add property at later stage if desired
  • updated unit test

Also added count of resources downloaded and added that to the log.

Verified in dev instance of Jenkins with numerous validations jobs. Also should pass cloudbees build.

@mosabua
Copy link
Member Author

mosabua commented Aug 4, 2016

Would be good to get this into the release @olivierdagenais @davidstaheli

@mosabua
Copy link
Member Author

mosabua commented Aug 4, 2016

Example output from a test job:

Getting version 'C3936' to '/build/workspace/admin/Verify/tfs_dev_sampleApp_build'...
Finished getting version 'C3936'. Retrieved 311 resources.

@olivierdagenais olivierdagenais self-assigned this Aug 4, 2016
@olivierdagenais
Copy link
Member

Nice and simple, approved!

Thank you for your contribution!

@olivierdagenais olivierdagenais merged commit 2c32125 into master Aug 4, 2016
@mosabua
Copy link
Member Author

mosabua commented Aug 4, 2016

Awesome .. you rock @olivierdagenais

@olivierdagenais olivierdagenais deleted the dontlogeachget branch August 15, 2016 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants