Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled parsing of TAP documents with corrupted YAML content #25

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

japod
Copy link

@japod japod commented Jun 4, 2019

The TAP parser should still fail by default if a corrupted YAML content is seen. The new config option , if set, changes the default behavior such that the parser strips out corrupted YAML parts while keeping the original test lines intact.

@japod
Copy link
Author

japod commented Jun 4, 2019

A simple test could be for example:

cat > result.tap << EOF
1..3
ok 1 one
ok 2 two
not ok 3 '0' should not be in window anymore
  ---
    type:    AssertionError
    message: '0' should not be in window anymore
  ...
ok 4 three
EOF

@kinow
Copy link
Member

kinow commented Jun 5, 2019

Tested with the default settings the the TAP stream above.

image

Then enabling the option to remove corrupted YAML

image

and

image

@kinow kinow merged commit a433cd2 into jenkinsci:master Jun 5, 2019
@japod japod deleted the remove-yaml-if-corrupted-feature branch June 5, 2019 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants