Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tap4j dependency upgraded to 4.4.2 version #24

Merged
merged 1 commit into from
Jun 3, 2019
Merged

tap4j dependency upgraded to 4.4.2 version #24

merged 1 commit into from
Jun 3, 2019

Conversation

japod
Copy link

@japod japod commented Jun 3, 2019 •
edited
Loading

This PR should address tupilabs/tap4j#56:

  • fixed sub-test related tests
  • target JDK version upgraded to 1.8 (as required by tap4j)

@japod japod mentioned this pull request Jun 3, 2019
Open
kinow
kinow approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, thanks for updating the tests. Did a quick mvn install, then mvn hpi:run, and created a simple project with something like

cat > 1.tap << EOF
1..2
ok 1
not ok 2
EOF

And it worked with no issues. LGTM

@kinow kinow merged commit 35b272f into jenkinsci:master Jun 3, 2019
@japod
Copy link
Author

japod commented Jun 4, 2019

Thanks for the quick response. I have some more additions for the plugin in the pipeline. Will push them in the coming days.

@japod japod deleted the tap4j-upgrade-4.4.2 branch June 4, 2019 07:19
@kinow
Copy link
Member

kinow commented Jun 4, 2019

Brilliant. Will try to check the issues and see if there's any pending issue that can go in the next release in the meantime too. Thanks @japod

@kinow kinow mentioned this pull request Jun 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinow kinow kinow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@japod @kinow