Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73280] Migrate to Jakarta EE 9 #584

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

Dohbedoh
Copy link
Contributor

@Dohbedoh Dohbedoh commented Oct 4, 2024

Started draft for Jakarta EE 9 migration.

Testing done

TBD

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Dohbedoh Dohbedoh added the chore label Oct 4, 2024
@Dohbedoh Dohbedoh requested a review from a team as a code owner October 4, 2024 02:44
@Dohbedoh Dohbedoh marked this pull request as draft October 4, 2024 02:44
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@Dohbedoh Dohbedoh marked this pull request as ready for review November 5, 2024 06:22
@Dohbedoh
Copy link
Contributor Author

Dohbedoh commented Nov 5, 2024

Rebased to fix the merge conflict. Should be good now.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally prefer using regular Git merge conflict resolution (from the GUI or CLI) since force-pushing makes it impossible for reviewers to check the incremental diff—have to start from scratch. Fortunately in this case the diff is fairly short.

@jglick jglick added dependencies Pull requests that update a dependency file and removed chore labels Nov 5, 2024
@jglick jglick added this pull request to the merge queue Nov 5, 2024
Merged via the queue into jenkinsci:master with commit 76b7034 Nov 5, 2024
17 checks passed
@Dohbedoh Dohbedoh deleted the chore/jakarta9 branch January 28, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants