Fix missing dependency on directly used trilead-api #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Lamy <olamy@apache.org>
olamy
commented
Mar 25, 2024
| @@ -3324,6 +3318,8 @@ public FormValidation doCheckLocal(@QueryParameter String value) throws IOExcept | |||
| * Enables trace logging of Ganymed SSH library. | |||
| * <p> | |||
| * Intended to be invoked from Groovy console. | |||
| * @deprecated | |||
There was a problem hiding this comment.
I would even remove this (and so dependency on trilead-api) as the class in trilead-api is even already deprecated.
https://github.com/jenkinsci/trilead-ssh2/blob/d9e5b647ca51e65db86e29a642f85eaee560bd10/src/com/trilead/ssh2/DebugLogger.java#L11
olamy
changed the title
Signed-off-by: Olivier Lamy <olamy@apache.org>
|
I've confirmed that incremental release 2.17.4-rc1255.4e4a_35243fd5 (from this pull request) resolves the test failure in the plugin bill of materials. Thanks @olamy ! |
MarkEWaite
approved these changes
Mar 25, 2024
MarkEWaite
added a commit
to MarkEWaite/bom
that referenced
this pull request
Mar 25, 2024
jenkinsci/ssh-credentials-plugin#199 makes the trilead-api plugin an optional dependency of the ssh-credentials plugin. That exposed a latent issue in the subversion plugin that is resolved in jenkinsci/subversion-plugin#284 . jenkinsci#3050 describes the details of the test failures in the plugin bill of mateerials. The failing tests can be seen with the commands: PLUGINS=subversion TEST=CompareAgainstBaselineCallableTest bash local-test.sh PLUGINS=mina-sshd-api-core LINE=weekly bash local-test.sh No need to block later releases, since the pull request thet fixes the issue has been submitted and is ready for review.
|
I'm not maintaining this functionally but I'll help with ecosystem related fixes if there's a working PR provided like in this case. |
jtnord
added a commit
to jtnord/pipeline-groovy-lib-plugin
that referenced
this pull request
Jun 17, 2024
updates the bom to 2950.va_633b_f42f759 to pick up jenkinsci/subversion-plugin#284
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olivier Lamy olamy@apache.org
Testing done
Submitter checklist