-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-44892] DescribableModel customization #43
[JENKINS-44892] DescribableModel customization #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change would only have limited effect on Job DSL. It is not possible to pass arbitrary arguments to DescribableModel.instantiate
as it is possible in Pipeline (from what I understand). Job DSL does strict checks to allow only DescribableParameter
s to be passed as arguments for instantiation. The change will help to provide better backwards-compatibility like for JENKINS-51638, but it will not be possible to mitigate a removed DataBoundSetter
. IMHO this change provides a missing hook, but does not address all use cased mentioned in JENKINS-44892, especially I do not see how the GerritTrigger case could be handled for Job DSL.
I think if JENKINS-33217 were implemented properly (inside |
JENKINS-44892: API permitting plugins which define structs to fine-tune how their surface form is presented, particularly in Pipeline Groovy.