Use Java 8 in annotation tests #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests were still using Java 6. This updates them to use Java 8. The addition of
-Xlint:noneis because otherwise the tests fail with erors like "warning: Supported source versionRELEASE_6from annotation processornet.java.dev.hickory.prism.internal.PrismGeneratorless than-source 1.8". Fixing this would require patchingPrismGenerator, which doesn't even exist on GItHub (much less with any activity in the past decade), or finding some other library or method of testing annotation processors, both of which are a bit more effort than I'm willing to put in at the moment, so silencing the linter warnings in the tests seemed like the easiest choice.