Convert GString
to String
when bridging to jelly.
#202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a groovy view and passing a groovy expression as
"${e1}${e2}"
to a taglib, the resulting value is not coerced to aString, which can lead to incorrect results when calling functions from
within jelly.
For example, when declaring a widget in Jenkins, using the following
index.groovy
as viewIn the resulting map that is passed to
JellyBuilder
,id
has typeGStringImpl
, unliketitle
orcollapsedText
which get coerced toString
.Then in https://github.com/jenkinsci/jenkins/blob/62546443947fafecc94a5e3b47bb9129bed8e148/core/src/main/resources/lib/layout/pane.jelly#L51, the function call doesn't happen because
attr.id
is aGString
, not aString
.@jglick