Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum jenkins version to 2.164.3 #1

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Conversation

timja
Copy link
Member

@timja timja commented Apr 10, 2020

Hi I'm trying to bump the version of jcasc in the bom, but this is blocked on this plugin having a core dep of 2.204, in order to introduce this plugin to the bom it needs to have a version available on all supported lines,

we're dropping the 2.150 line which makes 2.164.x the minimum required line,

would you consider dropping your minimum so that this can be added to the bom and the jcasc plugin version can be increased there?

cc @escoem @amuniz
jenkinsci/bom#214

ref jenkinsci/bom#214

@jetersen
Copy link
Member

@escoem @amuniz a release would be much appreciated :)

@timja
Copy link
Member Author

timja commented Apr 16, 2020

Pretty please?

@jetersen
Copy link
Member

Perhaps would be nice if we could get release permissions? 🤔

@jetersen
Copy link
Member

@amuniz
Copy link
Member

amuniz commented Apr 16, 2020

Oops, sorry, I didn't receive any notification about this... need to review my filters.

BTW I don't have permissions on this repo, would you mind to include me in the PR @jetersen?

@jetersen
Copy link
Member

@amuniz sure thing!

@escoem escoem merged commit 34ae72a into jenkinsci:master Apr 16, 2020
@jetersen
Copy link
Member

@escoem thanks for releasing it 👏

@jtnord
Copy link
Member

jtnord commented Apr 16, 2020

this add back triliead-api as an implied dependency for a version of core that is arbitrary. There are no security fixes for 2.164 from tomorrow (Cloudbees was the only company I am aware of that was providing them) and that leaves 2.190 as a lowest version that gets security fixes.

looking at install trend for casc of people that upgrade (say 1.35) 87% of people are on 2.190 or newer. if you take 1.36 then that number increases above 90%...

allowing users to keep getting features on insecure jenkins versions is an anti pattern that we should be trying to stopp

@timja
Copy link
Member Author

timja commented Apr 16, 2020

this add back triliead-api as an implied dependency for a version of core that is arbitrary. There are no security fixes for 2.164 from tomorrow (Cloudbees was the only company I am aware of that was providing them) and that leaves 2.190 as a lowest version that gets security fixes.

looking at install trend for casc of people that upgrade (say 1.35) 87% of people are on 2.190 or newer. if you take 1.36 then that number increases above 90%...

allowing users to keep getting features on insecure jenkins versions is an anti pattern that we should be trying to stopp

@jtnord we just need one release on a low version for bom so there's at least one version on each bom line and then it can be increased again

@timja
Copy link
Member Author

timja commented Apr 16, 2020

also @jtnord 1.37 has a minimum version of ~2.220 we are fine with bumping the version, but currently because of how bom is setup, a plugin has to have at least 1 one release on all supported lines

@timja timja mentioned this pull request Apr 16, 2020
@jtnord
Copy link
Member

jtnord commented Apr 16, 2020

@timja thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants