Fixing -direct

[jglick]

#677 (comment) by code inspection; have not yet checked how to test in Kubernetes (would require building an agent image from source).

[Vlatombe]

Looks reasonable

[jglick]

Testing manually using 2.414.3 (no K8s). Without patch:

$ java -jar target/remoting-999999-SNAPSHOT.jar -direct localhost:42345 -instanceIdentity MIIB… -secret … -name x -protocols JNLP4-connect
WARNING: Are you running agent from an interactive console?
If so, you are probably using it incorrectly.
See https://wiki.jenkins.io/display/JENKINS/Launching+agent+from+console
<===[JENKINS REMOTING CAPACITY]===>rO0ABXNyABpodWRzb24ucmVtb3RpbmcuQ2FwYWJpbGl0eQAAAAAAAAABAgABSgAEbWFza3hwAAAAAAAAAf4=

With patch:

Oct 23, 2023 9:30:10 AM hudson.remoting.Launcher createEngine
INFO: Setting up agent: x
Oct 23, 2023 9:30:10 AM hudson.remoting.Engine startEngine
INFO: Using Remoting version: 999999-SNAPSHOT (private-10/23/2023 13:28 GMT-jglick)
Oct 23, 2023 9:30:10 AM hudson.remoting.Engine startEngine
WARNING: No Working Directory. Using the legacy JAR Cache location: /home/jglick/.jenkins/cache/jars
Oct 23, 2023 9:30:10 AM hudson.remoting.Launcher$CuiListener status
INFO: Locating server among []
Oct 23, 2023 9:30:10 AM hudson.remoting.Launcher$CuiListener status
INFO: Agent discovery successful
  Agent address: localhost
  Agent port:    42345
  Identity:      7c:0b:06:67:34:ae:2d:86:b6:3a:76:fa:22:44:31:7b
Oct 23, 2023 9:30:10 AM hudson.remoting.Launcher$CuiListener status
INFO: Handshaking
Oct 23, 2023 9:30:10 AM hudson.remoting.Launcher$CuiListener status
INFO: Connecting to localhost:42345
Oct 23, 2023 9:30:10 AM hudson.remoting.Launcher$CuiListener status
INFO: Server reports protocol JNLP4-connect-proxy not supported, skipping
Oct 23, 2023 9:30:10 AM hudson.remoting.Launcher$CuiListener status
INFO: Trying protocol: JNLP4-connect
Oct 23, 2023 9:30:10 AM org.jenkinsci.remoting.protocol.impl.BIONetworkLayer$Reader run
INFO: Waiting for ProtocolStack to start.
Oct 23, 2023 9:30:10 AM hudson.remoting.Launcher$CuiListener status
INFO: Remote identity confirmed: 7c:0b:06:67:34:ae:2d:86:b6:3a:76:fa:22:44:31:7b
Oct 23, 2023 9:30:10 AM hudson.remoting.Launcher$CuiListener status
INFO: Connected