Fix proxy authentication #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #677 I noticed that proxy authentication was broken even on trunk, no matter which combination of entrypoints and parameters I tried. If we advertise a
-proxyCredentialsflag, then it should at least work. This PR gets the flag to work as advertised.Testing done
Set up a Squid forward proxy that required authentication, then ran:
java -Djdk.http.auth.tunneling.disabledSchemes= -Dhttp.proxyHost=${IP_ADDRESS} -Dhttp.proxyPort=3128 -jar target/remoting-999999-SNAPSHOT.jar -url ${JENKINS_URL} -secret ${SECRET} -name test -proxyCredentials ${USERNAME}:${PASSWORD}Before this PR it either failed either in the
isPortVisiblemethod or when trying to actually establish the tunnel. Now it works in both places.