-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can withPythonEnv
block also affect sh
steps?
#6
Comments
Plugging into the Since virtualenv works primarily through the manipulation of environmental variables, it is theoretically possible to supply the manipulated environment to each This is why I made the decision to use |
Actually, after poking around some more, there may be a way to accomplish this. I need to mess around with it, and will report back here |
After poking around a bit, I believe that I can capture the relevant changes in EnvVars that the virtualenv makes, and make those changes available within the body of Life has been getting in the way recently, and I apologize for the delay. As soon as I get a little extra time I will knock this out |
Awesome news about possibly being able to do it with environment variables! I understand life getting in the way. Take your time; in the meantime, it's just two more characters for us to type, it's not more important than the rest of your life. |
This was a pretty major change to the plugin. In order to bring this plugins functionality more in line with Jenkins idioms, I changed the withPythonEnv step to apply environmental variable changes skimmed from the activiation of the virtualenv. This is how virtualenv works under the hood when active anyways. As such, we no longer need the pybat and pysh steps, the regular sh and bat steps work as intended. These have been removed as part of this commit
This functionality has been added, and will be released shortly as version 2.0.0 |
This plugin is useful, but multiple people in my organization, when trying it, have missed the fact that any commands you want to run within a virtualenv must be invoked as
pysh
steps instead of regularsh
.The typical behavior we've come to expect for withSomething{} pipeline blocks (withEnv, withCredentials, etc) has been that they affect the behavior of every shell command within the block; is there a reason (technical or philosophical) for separating out that behavior in this plugin?
The text was updated successfully, but these errors were encountered: