Changed to use WorkspaceList.allocate instead of acquire. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove whitespace changes. They complicate merges of parallel PRs |
mellowplace
force-pushed
the
QUICK_LOCK_FIX
branch
from
36bc08a
to
2875fc7
Compare
Acquiring a quick lock causes parallelised builds to back up waiting for the workspace to become available. This is because WorkspaceList.allocate will give executing jobs the first workspace as the given lock is a quick lock. Then builds will wait in WorkspaceList.acquire all trying to get the same workspace.
mellowplace
force-pushed
the
QUICK_LOCK_FIX
branch
from
2875fc7
to
0f68d6f
Compare
|
Whitespace changes made - I notice 3 tests timed out - is that related to this change @oleg-nenashev ? |
|
@mellowplace No, it's a CI infra issue AFAIK. Thanks for cleaning up the code |
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acquiring a quick lock causes parallelised builds to back up waiting for
the workspace to become available. This is because WorkspaceList.allocate
will give executing jobs the first workspace as the given lock is a quick
lock. Then builds will wait in WorkspaceList.acquire all trying to get
the same workspace.
This change is