Update to the latest jenkins plugin version 4.8 #50

fr123k · 2020-05-09T17:32:54Z

update the pom definition to the jenkins plugin version 4.1
update the plugin specific code to support plugin version 4.1 and
be fully compatible with the casc plugin (configuration as code)

The already defined tests are all passing at least most of the time. I also
tested the compatibility of the configuration with the version 3.6.0. But i can't
guaranty full compatibility at this point.

I would also like to take over the maintainer role of this plugin and will follow
the take over guide in the next days.

I just came across those plugin working on my own one that needed a way to
prioritize jobs. Instead of implementing this and i spend the time to update this
plugin to the latest jenkins version in order to use the jenkins casc plugin (configuration as code)

Thanks Brad Larson and Magnus Sandberg for providing amnd mainting this plugin.

* update the pom definition to the jenkins plugin version 4.1 * update the plugin specific code to support plugin version 4.1 and be fully compatible with the casc plugin (configuration as code)

JungPhilipp · 2020-08-18T09:04:58Z

We are very interested to get this plugin working with Configuration as Code. Any chance this will get implemented in the near future?

FnTm · 2020-09-24T07:35:36Z

@fr123k thank you for taking the time to do this! I'm also very interested in using priority sorter with JCasC. Are there any news on that front?

pussinboots · 2020-10-01T13:36:44Z

Upcoming week i will update the PR and hope for green build light.

oleg-nenashev · 2020-10-01T14:41:08Z

pom.xml

+    <parent>
+        <groupId>org.jenkins-ci.plugins</groupId>
+        <artifactId>plugin</artifactId>
+        <version>4.1</version>


Now there is 4.8 with a few more updates

oleg-nenashev

Just a few comments. Looks very promising!

pom.xml

README.md

oleg-nenashev · 2020-10-01T14:45:01Z

FTR Ownership transfer request: https://groups.google.com/g/jenkinsci-dev/c/7s2xdiHg0QA

This documentation ia auto generated. https://plugins.jenkins.io/release/#dependencies

oleg-nenashev

Would be also great to clean up the commented code. We have commit history if we ever need to retrieve it.
Otherwise it is nice to have a comment explaining why it is commented

pom.xml

The maintainer information is extracted from the [repository-permissions-updater](https://github.com/jenkins-infra/repository-permissions-updater) instead. [WEBSITE-658](https://issues.jenkins-ci.org/browse/WEBSITE-658)

oleg-nenashev

I still need to go though the entire code. The changes look good overall, but ithe code does not retain binary compatibility with the previous version. I am also not sure about data compatibility.

What I recommend to do:

Change the target version to 3.0-SNAPSHOT. It does not make much sense to try retainining binary compatibility here (famous last word? might make sense to check plugins depending on this one).
Add tests which would load the old configuration file (@LoadData annotation in Jenkins Test Harness) and verify that they are properly loaded in the new version. If not, an additiona; migration code or documentation will be needed.

oleg-nenashev · 2020-10-09T08:34:11Z

src/main/java/jenkins/advancedqueue/JobGroup.java

+		this.jobGroupStrategy = jobGroupStrategy;
+		this.runExclusive = runExclusive;
+		this.usePriorityStrategies = usePriorityStrategies;
+		/*


Copy-pasted from newInstance()? Please either cleanup the comment or add a TODO describing why t is commented out. Also, the entire newIInstance() might not longer be needed when you have a constructor

The newInstance method is used by the PriorityConfiguration.doPriorityConfigSubmit to serialize the changes done on the /advanced-build-queue configuration page.

At the moment i am missing knowledge on the how this jelly DataBinding works. If this setup is fixed then i guess this method is obsolete.

For now i removed the not used full args constructor of the JobGroup class.

oleg-nenashev · 2020-10-09T08:35:01Z

src/main/java/jenkins/advancedqueue/JobGroup.java

@@ -140,7 +196,7 @@ public int getPriority() {
 	 * @deprecated Used in 2.x now replaced with dynamic {@link JobGroup#jobGroupStrategy}, will return the view
 	 */
 	@Deprecated
-        @CheckForNull
+    @CheckForNull


Tabs vs. spaces in this and other files. Maybe it makes sense to just add a bulk refactoring in a follow-up pull request

In the single commit 89a142e
all tabs are replaced with whitespaces.

oleg-nenashev · 2020-10-09T08:39:05Z

src/main/java/jenkins/advancedqueue/JobGroup.java


-	private JobGroup() {
+	@DataBoundConstructor
+	public JobGroup(int id, String description, int priority, JobInclusionStrategy jobGroupStrategy, boolean runExclusive, boolean usePriorityStrategies, List<? extends PriorityStrategy> priorityStrategies) {


It does not look like you use this constructor anywhere except data binding. For data binding there is no need to repeat fields in the constrictor if you have @DataBoundSetters defined

oleg-nenashev · 2020-10-09T08:41:34Z

src/main/java/jenkins/advancedqueue/JobGroup.java

+		List<PriorityStrategy> B = priorityStrategyHolders.stream()
+        .map(holder -> holder.priorityStrategy)
+        .collect(Collectors.toList());
+		return B;
 	}

 	/**


Most likely, newInstance() is no longer required,unless there are internal dependencies on this deprecated databinding mechanism

Will keep newInstance and do a Refactoring to the new DataBound mechanism later.
Can you point me to a good documentation or example code of it.

LICENSE.txt

Hi as ask in the FTR Ownership transfer request here is the release permission PR request for the [priority-sorter-plugin](https://github.com/jenkinsci/priority-sorter-plugin) [FTR Ownership tranfer request](https://groups.google.com/g/jenkinsci-dev/c/7s2xdiHg0QA) [Priority Sorter PR](jenkinsci/priority-sorter-plugin#50) Looking forward to my first release to the jenkins Artifactory. Co-authored-by: Frank Ittermann <frank.ittermann@data4life.care>

Also removed not necessary witespaces as well. * trailing * blank lines

pussinboots · 2020-10-10T09:21:07Z

Add tests which would load the old configuration file (@loaddata annotation in Jenkins Test Harness) and verify that they are properly loaded in the new version. If not, an additiona; migration code or documentation will be needed.

Under src/test/resources/jenkins/advancedqueue/test/ there a couple of old configuration files that were not changed and still used in all the different tests.

There is only one test that is skipped now MatrixTest.matrix_and_jobs_with_no_configuration its shaky.

At the moment there are no test for JCasC configuration.

pussinboots · 2020-10-12T20:26:16Z

@jungstar @FnTm

What you can do is to fork this branch and build the plugin your own and install it in jenkins
manually. An example of a JCasC configuration ofr can be obtained from https://github.com/fr123k/jenkins-aws-pulumi/blob/8d5d55ac89db8685c63bc365bd2b39d424594a32/jenkins/config/casc-config/agents.yaml#L39.

On docker hub there is also a image provided that has the new version of this plugin already installed. For this checkout the following github repository https://github.com/fr123k/jocker (jocker - jenkins in docker).

This way you can also provided feedback if something with JCasC and this version of the plugin is not working as expected.

oleg-nenashev · 2021-03-08T13:08:45Z

losing in favor of #51 . Thanks anyway @fr123k !

fr123k force-pushed the master branch 3 times, most recently from fd008db to cf9f43b Compare May 17, 2020 19:38

Update to the latest jenkins plugin version 4.1

6a588ad

* update the pom definition to the jenkins plugin version 4.1 * update the plugin specific code to support plugin version 4.1 and be fully compatible with the casc plugin (configuration as code)

fr123k force-pushed the master branch from cf9f43b to 6a588ad Compare May 24, 2020 09:32

oleg-nenashev reviewed Oct 1, 2020

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

fr123k added 3 commits October 4, 2020 19:18

Update to jenkings plugin verssion 4.8

0a7b9b1

Update to 2.235 and use jenkinsci/bom dependency management

4dc453a

Remove Dependency section from Readme

abf1de5

This documentation ia auto generated. https://plugins.jenkins.io/release/#dependencies

oleg-nenashev reviewed Oct 5, 2020

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

pom.xml Outdated Show resolved Hide resolved

Update to bom version 12 and remove commented lines.

2a24b27

fr123k changed the title ~~Update to the latest jenkins plugin version 4.1~~ Update to the latest jenkins plugin version 4.8 Oct 9, 2020

Remove developer maven metadata

0b78e21

The maintainer information is extracted from the [repository-permissions-updater](https://github.com/jenkins-infra/repository-permissions-updater) instead. [WEBSITE-658](https://issues.jenkins-ci.org/browse/WEBSITE-658)

fr123k mentioned this pull request Oct 9, 2020

Request release permission for priority-sorter plugin jenkins-infra/repository-permissions-updater#1715

Merged

14 tasks

Add jenkins build badge to the Readme

53df3b7

oleg-nenashev requested changes Oct 9, 2020

View reviewed changes

Replace all tabs with whitespaces

89a142e

Also removed not necessary witespaces as well. * trailing * blank lines

fr123k added 4 commits October 12, 2020 22:12

Speedup mvn builds with MAVEN_ARGS?=-T 4

63b5772

Change the target version to 3.0-SNAPSHOT

d292c99

Remove not used JobGroup full args constructor

ed0d06f

Cleanup PriorityConfiguration class code

9d3840c

fr123k requested a review from oleg-nenashev November 2, 2020 01:10

oleg-nenashev closed this Mar 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to the latest jenkins plugin version 4.8 #50

Update to the latest jenkins plugin version 4.8 #50

fr123k commented May 9, 2020

JungPhilipp commented Aug 18, 2020

FnTm commented Sep 24, 2020

pussinboots commented Oct 1, 2020

oleg-nenashev Oct 1, 2020

oleg-nenashev left a comment

oleg-nenashev commented Oct 1, 2020

oleg-nenashev left a comment •

edited

Loading

oleg-nenashev left a comment

oleg-nenashev Oct 9, 2020

pussinboots Oct 11, 2020

pussinboots Oct 12, 2020

oleg-nenashev Oct 9, 2020

pussinboots Oct 10, 2020

oleg-nenashev Oct 9, 2020

oleg-nenashev Oct 9, 2020

pussinboots Oct 12, 2020

pussinboots commented Oct 10, 2020

pussinboots commented Oct 12, 2020 •

edited

Loading

oleg-nenashev commented Mar 8, 2021

Update to the latest jenkins plugin version 4.8 #50

Update to the latest jenkins plugin version 4.8 #50

Conversation

fr123k commented May 9, 2020

JungPhilipp commented Aug 18, 2020

FnTm commented Sep 24, 2020

pussinboots commented Oct 1, 2020

Choose a reason for hiding this comment

oleg-nenashev left a comment

Choose a reason for hiding this comment

oleg-nenashev commented Oct 1, 2020

oleg-nenashev left a comment • edited Loading

Choose a reason for hiding this comment

oleg-nenashev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pussinboots commented Oct 10, 2020

pussinboots commented Oct 12, 2020 • edited Loading

oleg-nenashev commented Mar 8, 2021

oleg-nenashev left a comment •

edited

Loading

pussinboots commented Oct 12, 2020 •

edited

Loading