JENKINS-69757 Improve priority sorter plugin automated test coverage #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
995560375
changed the title
MarkEWaite
requested changes
May 16, 2023
There was a problem hiding this comment.
Thanks for the pull request. There is one minor item that needs to be adjusted and then it is ready to merge.
In future pull requests, please create a new branch that contains your changes rather than placing your changes on a branch named master. When your branch is named master it complicates the review process for maintainers like me.
You can read more about creating a pull request in the "Improve a plugin" tutorial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-69757
This pull request introduces new tests for the PrioritySorterConfiguration class, specifically targeting the doFillStrategyItems method.
The doFillStrategyItems method is responsible for populating a ListBoxModel with the display names and keys of all sorter strategies. The test, testDoFillStrategyItems, ensures that this List BoxModel is correctly populated.
The test leverages Mockito to mock the SorterStrategyDescriptor instances and their respective methods, getDisplayName and getKey. It verifies that the ListBoxModel returned by doFillStrategyItems contains the correct number of items and that each item's name and value match the expected values.