Make the plugin compileable again #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this. Some build jobs failed although everything went through in the past. So I decided to collect the updates and fix it all at once before a new release. |
NotMyFault
commented
Aug 30, 2023
| @@ -21,8 +21,8 @@ | |||
| <revision>3.2.0</revision> | |||
| <changelist>999999-SNAPSHOT</changelist> | |||
| <gitHubRepo>jenkinsci/postbuildscript-plugin</gitHubRepo> | |||
| <java.level>8</java.level> | |||
There was a problem hiding this comment.
Is obsolete and is no longer configured on a plugin-pom level.
Comment on lines
-25
to
+24
| <jenkins.version>2.359</jenkins.version> | ||
| <jenkins.version>2.414.1</jenkins.version> |
There was a problem hiding this comment.
Aligns with the baseline recommendation
| <java.level>8</java.level> | ||
| <jenkins.version>2.359</jenkins.version> | ||
| <jenkins.version>2.414.1</jenkins.version> | ||
| <hpi.compatibleSinceVersion>3.0.0</hpi.compatibleSinceVersion> |
There was a problem hiding this comment.
Inlined the property from the obsolete maven-hpi-plugin block
| @@ -101,7 +101,7 @@ | |||
| </contributors> | |||
|
|
|||
| <scm> | |||
| <connection>scm:git:git://github.com/${gitHubRepo}.git</connection> | |||
| <connection>scm:git:https://github.com/${gitHubRepo}.git</connection> | |||
There was a problem hiding this comment.
The former syntax is deprecated and emits a warning
| @@ -112,7 +112,6 @@ | |||
| <dependency> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>matrix-project</artifactId> | |||
| <version>808.v5a_b_5f56d6966</version> | |||
There was a problem hiding this comment.
Shipped by the BOM declared below
|
CI checks are succesful 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change proposed makes the plugin compilable again because the default branch can't be compiled at the moment.
Just for my understanding, is there a particular reason why you kept merging pull requests, even though these broke your default branch and failed the CI checks @dheid ?