Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump parent pom from 6.2.0 to 6.7.0 #92

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

alecharp
Copy link
Member

@alecharp alecharp commented Jul 4, 2024

In order to validate the plugin with Jetty 12, we need to get jenkinsci/plugin-pom#693 which is included in 4.62 version. That bump occurred on the analysis-pom version 6.7.0.

Testing done

None. Relying on the CI to build this.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

In order to validate the plugin with Jetty 12, we need to get jenkinsci/plugin-pom#693 which is included in `4.62` version. That bump occurred on the `analysis-pom` version `6.7.0`.
@uhafner
Copy link
Member

uhafner commented Jul 4, 2024

The plugin is deprecated and not used anymore. Wouldn't it make more sense to remove it from the tests?

@alecharp
Copy link
Member Author

alecharp commented Jul 4, 2024

I agree it would however, this is not something I can achieve as quickly as I would like to. And in the mean time, this would kinda resolve the problem I see in my Jetty 12 testing.

@uhafner uhafner merged commit d62c7ad into jenkinsci:master Jul 4, 2024
21 checks passed
@uhafner
Copy link
Member

uhafner commented Jul 4, 2024

Do you need a release as well?

@alecharp
Copy link
Member Author

alecharp commented Jul 4, 2024

Yes that would be perfect if you could release this. Thank you @uhafner for your help on this.

@alecharp alecharp deleted the patch-1 branch July 4, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants