Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump extra-enforcer-rules from 1.3 to 1.4 #445

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 27, 2021

Bumps extra-enforcer-rules from 1.3 to 1.4.

Release notes

Sourced from extra-enforcer-rules's releases.

1.4

🚀 New features and improvements

  • add dependabot and release drafter configurations (#138) @​olamy
Commits
  • fffd377 [maven-release-plugin] prepare release extra-enforcer-rules-1.4
  • a91ca9b Bump mockito-core from 3.11.2 to 3.12.4 (#139)
  • a7c1f7b Bump mojo-parent from 60 to 63 (#142)
  • 3df79ea add dependabot and release drafter configurations (#138)
  • d380fe5 Upgrade to maven-enforcer-api 3.0.0; Require Maven 3.1.1
  • f428f30 improve build configuration
  • 3e1f7f8 Update dependencies and plugin versions to version before m-enforcer-plugin 3...
  • 7ade053 Bump maven-dependency-tree from 2.1 to 2.2
  • 5e34e58 Update dependencies and plugins.
  • c97a9d2 Refactor AbstractRequireRoles.getRolesFromString
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 27, 2021
@timja
Copy link
Member

timja commented Sep 27, 2021

Enforce 3.0.0 fails with the servlet API hack and something to do with jetty

Any ideas @jglick / @jtnord

@jglick
Copy link
Member

jglick commented Sep 27, 2021

Not sure, but I would love to remove https://github.com/jenkinsci/jenkins/blob/73522166a4f55e8dc225d30268a512e5cb7b5d28/pom.xml#L141-L158 in favor of a proper Enforcer rule (if we do not already have one).

@jtnord
Copy link
Member

jtnord commented Sep 27, 2021

Spring security requires javax.servlet:javax.servlet:4.0.1 jetty uses 3.x so this may well be a real issue we just did not see elsewhere.

This is not the hack which is javax.servlet:servlet-api which also fails but is a bit strange. I'm still looking

@basil
Copy link
Member

basil commented Nov 15, 2021

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 15, 2021

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@basil
Copy link
Member

basil commented Nov 15, 2021

@dependabot recreate

Bumps [extra-enforcer-rules](https://github.com/mojohaus/extra-enforcer-rules) from 1.3 to 1.4.
- [Release notes](https://github.com/mojohaus/extra-enforcer-rules/releases)
- [Commits](mojohaus/extra-enforcer-rules@extra-enforcer-rules-1.3...extra-enforcer-rules-1.4)

---
updated-dependencies:
- dependency-name: org.codehaus.mojo:extra-enforcer-rules
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/org.codehaus.mojo-extra-enforcer-rules-1.4 branch from 4c5eb18 to e478b73 Compare November 15, 2021 22:26
@basil
Copy link
Member

basil commented Nov 16, 2021

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 16, 2021

Looks like org.codehaus.mojo:extra-enforcer-rules is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Nov 16, 2021
@dependabot dependabot bot deleted the dependabot/maven/org.codehaus.mojo-extra-enforcer-rules-1.4 branch November 16, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants