Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-35697] Avoid losing the focus because ForkedBooter on MacOS when running tests #443

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

MRamonLeon
Copy link
Contributor

Added a couple of arguments to the jvm that is forked when running tests to avoid losing the focus when you run the maven tests in the background in MacOS. It's very annoying every time a fork is created you lose the focus where you were.

I manually tested with a plugin using this modified version. When the plugin run the tests, the Java icon doesn't show up anymore.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

pom.xml Show resolved Hide resolved
@timja timja merged commit 54448bf into jenkinsci:master Sep 24, 2021
jglick added a commit to jglick/plugin-pom that referenced this pull request Oct 4, 2021
jglick added a commit that referenced this pull request Oct 4, 2021
Revert #443 (`argLine` modification)
@jglick jglick changed the title Avoid losing the focus because ForkedBooter on MacOS when running tests [JENKINS-35697] Avoid losing the focus because ForkedBooter on MacOS when running tests Oct 18, 2021
@jglick
Copy link
Member

jglick commented Oct 18, 2021

This was reverted. Could try to create a safer patch. https://issues.jenkins.io/browse/JENKINS-35697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants