Ban TestNG dependency #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to have a brief comment with explanation directly in pom.xml, e.g. as a comment Jenkins Test Harness is largely based on JUnit, and it is not trivial to have a TestNG equivalent (or JUnit 5 for the same reason) |
|
Hi @oleg-nenashev, I have added comment as requested. |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a big fan of TestNG, this was my default choice when selecting unit test framework for my Jenkins plugin. As I wanted to add an end-to-end integration test and make use of Jenkins test harness provided (JenkinsRule and BuildWatcher), I configured my Maven project to use TestNG for unit tests and JUnit for ITs. I soon realised having two test frameworks in a single project is (slightly) overengineered and moved my unit tests to JUnit. It was a surprise for me when I noticed there were now 5 more tests (InjectedTest) - failing - which were not running before when I used TestNG for my unit tests. Having Maven run both TestNG and JUnit tests has always been problematic and required sometimes "not so nice" workarounds. There are many resources on this topic, including this one. My preference is to avoid such situation in first place, if possible.
Long story short, even if I don't have a single TestNG unit test in my test codebase, but define TestNG dependency in pom.xml, InjectedTest will not run. I'm opening this PR to ban TestNG dependency, so that people do not unknowingly disable InjectedTest.