Hack for io.jenkins.configuration-as-code:test-harness #344
Conversation
| @@ -1016,6 +1016,12 @@ private void addSplitPluginDependencies(String thisPlugin, MavenRunner.Config mc | |||
| toAddTest = difference(pluginDeps, toAddTest); | |||
| toAddTest = difference(toAdd, toAddTest); | |||
|
|
|||
| if (toReplaceTest.containsKey("configuration-as-code")) { | |||
There was a problem hiding this comment.
Given this is a special case, wouldn't it be better to use a hook instead of hacking the default logic? TBH I am missing the context so whatever you believe is better. The hook approach means easier code but at the same time is harder to follow what is happening unless you are aware of the PCT hook mechanism. No feeling strongly to push for it if you prefer this way
There was a problem hiding this comment.
unsure, this isn't really for merge it's a continuation of #276
Which just has 7269bed applied on top of it
Integration tests fail I think because the tests need to be updated to use newer configuration as code as it's trying to always add the test harness but the test harness doesn't exist on the old version pinned in the config here.
And can't merge master in because #299 breaks bom quite badly.
A number of InjectedTest fail in bom and we're okay with that (other plugins need updating in the pom file and need to override bom as well for it to work properly I think), but that PR 'correctly' catches that there was an error in test startup
There was a problem hiding this comment.
A number of
InjectedTestfail in bom and we're okay with that
jenkinsci/bom#341 you mean?
There was a problem hiding this comment.
(note comment in jenkinsci/bom#610)
There was a problem hiding this comment.
A number of
InjectedTestfail in bom and we're okay with thatjenkinsci/bom#341 you mean?
Yes
|
Presumed obsolete after jenkinsci/bom#1336. |
alternate to #343