Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-61597] Use freebsd-version for jail version number #178

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Apr 15, 2020

JENKINS-61597 Use freebsd-version for jail version number

Using the uname output on FreeBSD provides the kernel version. The userland version is much more relevant, especially in FreeBSD jails. This changes the behavior to label the agent with the userland version rather than the kernel version.

This change makes FreeBSD jail behaviors closer to the behavior of Docker images. When a Docker image reports its operating system, it reads the userland values, not the kernel values.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Using the uname output on FreeBSD provides the kernel version.  The
userland version is much more relevant, especially in FreeBSD jails.
This changes the behavior to label the agent with the userland
version rather than the kernel version.

This change makes FreeBSD jail behaviors closer to the behavior of
Docker images.  When a Docker image reports its operating system,
it reads the userland values, not the kernel values.
@MarkEWaite MarkEWaite added the enhancement Improvement or new feature label Apr 15, 2020
@MarkEWaite MarkEWaite merged commit 3faf98e into jenkinsci:master Apr 15, 2020
@MarkEWaite MarkEWaite deleted the use-freebsd-version branch April 15, 2020 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant