Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert several tests to use JUnit 5 #115

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

MarkEWaite
Copy link
Contributor

Convert most tests to JUnit 5

Use JUnit 5 framework for tests instead of JUnit 4.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No spotbugs warnings were introduced with my changes

Types of changes

  • Refactoring

Further comments

No Rule support in JUnit 5, so no replacement for JenkinsRule yet.

No Rules in JUnit 5, cannot convert JenkinsRule yet
@MarkEWaite MarkEWaite added the test Automated test addition or improvement label Oct 23, 2019
@MarkEWaite MarkEWaite merged commit 3be5965 into jenkinsci:master Oct 23, 2019
@MarkEWaite MarkEWaite deleted the use-junit-5 branch October 23, 2019 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant