[JENKINS-72611] Do not update credentials ID in BaseTest
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
approved these changes
Mar 4, 2024
jtnord
reviewed
Mar 4, 2024
| @@ -108,7 +107,7 @@ private <T extends BaseStandardCredentials> void testCreateUpdateDelete(T creden | |||
| assertThat(credentials.size(), is(1)); | |||
| cred = credentials.get(0); | |||
| assertThat(cred, instanceOf(credential.getClass())); | |||
| assertThat(cred.getId(), is(UPDATED_CRED_ID)); | |||
| assertThat(cred.getId(), is(CRED_ID)); | |||
There was a problem hiding this comment.
check the comment at the top of this block :)
|
Was gonna push an update to address James' comment. Do I file a new clean up PR or leave as is? |
|
Oh sorry. A separate PR to clean up the comment would be fine. |
yaroslavafenkin
added a commit
to yaroslavafenkin/plain-credentials-plugin
that referenced
this pull request
Mar 4, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of jenkinsci/credentials-plugin#506.
PCT currently fails with jenkinsci/credentials-plugin#506 (comment).
Testing done
Submitter checklist