Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to use jcasc test harness #20

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Conversation

timja
Copy link
Member

@timja timja commented Jan 18, 2020

Support plugin is long dead

New credentials plugin version requires 2.138.4

New plugin-pom requires minimumJavaVersion if you're overriding its config, (not entirely sure if the override is still needed though.

Bit of modernising done in the jcasc test while I was here

@timja timja requested a review from jglick January 18, 2020 22:17
Copy link
Member

@jvz jvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, thanks!

@timja timja requested a review from stephenc January 20, 2020 20:09
@timja
Copy link
Member Author

timja commented Jan 24, 2020

@jvz any chance you could ping someone internally to merge / release this please? 😄

@jvz
Copy link
Member

jvz commented Jan 27, 2020

@jeffret-b or @Wadeck can we get this merged and released?

@jeffret-b
Copy link
Contributor

It looks like I don't have all the correct permissions to merge this. I'll check around to get the right permissions and then I'll merge and release.

@timja
Copy link
Member Author

timja commented Jan 29, 2020

@jeffret-b permissions are sorted now

@jeffret-b
Copy link
Contributor

Looks like I have merge permissions. I'll work on this later on today as soon as I get a chance.

@jeffret-b jeffret-b added dependencies chore For changelog: A maintenance chore with no functional changes ready-to-merge labels Jan 29, 2020
@jeffret-b jeffret-b merged commit d397661 into jenkinsci:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore For changelog: A maintenance chore with no functional changes dependencies ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants